Skip to content

[ISSUE #4191] Do some code optimization.[StreamPushRequest] #4355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
himansh295 wants to merge 3 commits into from
Closed

[ISSUE #4191] Do some code optimization.[StreamPushRequest] #4355

himansh295 wants to merge 3 commits into from

Conversation

@himansh295
Copy link
Contributor

@himansh295 himansh295 commented Aug 13, 2023 •
edited by pandaapo
Loading

Fixes #4191.

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@harshithasudhakar
Copy link
Member

harshithasudhakar commented Aug 13, 2023

@himansh295 Please standardize your PR title and Fixes, also resolve the merge conflicts.

mxsm
mxsm requested changes Aug 13, 2023
View reviewed changes
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@himansh295 Has conflicts that must be resolved

@himansh295
Merge branch 'master' into himansh295/issue-4191
5183ce4 
# Conflicts:
#	eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/push/StreamPushRequest.java
@himansh295
Issue-4191 : Enhancement changes done update branch with latest master
9038989
@himansh295
Copy link
Contributor Author

himansh295 commented Aug 13, 2023 •
edited
Loading

@mxsm Updated the PR with the pull of the latest master.Please check again

@mxsm
Copy link
Member

mxsm commented Aug 13, 2023

@mxsm Updated the PR with the pull of the latest master.Please check again

@himansh295 you can rebase or merge master and fix conflicts, Then submit agagin

@mxsm mxsm changed the title Issue-4191 : Enhancement changes done [ISSUE #4191]Enhancement changes done Aug 13, 2023
@pandaapo pandaapo changed the title [ISSUE #4191]Enhancement changes done [ISSUE #4191] Do some code optimization.[StreamPushRequest] Aug 13, 2023
@himansh295
Copy link
Contributor Author

himansh295 commented Aug 13, 2023

Please check for the new PR for the same issue I have created. Making this PR close.
@mxsm .
PR -#4356

@himansh295 himansh295 closed this Aug 13, 2023
@himansh295 himansh295 deleted the himansh295/issue-4191 branch August 13, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxsm mxsm mxsm requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Enhancement] Do some code optimization.[StreamPushRequest]

3 participants

@himansh295 @harshithasudhakar @mxsm