This repository was archived by the owner on Apr 4, 2021. It is now read-only.
FALCON-1909 Catalog instance triage action fails with null pointer ex… #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public CatalogStorage(Cluster cluster, CatalogTable table) throws URISyntaxException { | ||
| this(ClusterHelper.getInterface(cluster, Interfacetype.REGISTRY).getEndpoint(), table); | ||
| verifyAndUpdateConfiguration(getConf()); |
Contributor
There was a problem hiding this comment.
You don't need it here. verifyAndUpdateConfiguration is already called in CatalogStorage(String catalogUrl, CatalogTable table).
| parseFeedUri(tableUri); | ||
| } | ||
|
|
||
| private void verifyAndUpdateConfiguration(Configuration conf) { |
Contributor
There was a problem hiding this comment.
Could you move this to be under all the CatalogStorage functions?
Contributor
|
+1 |
1 similar comment
|
+1 |
Contributor
|
+1 LGTM |
pallavi-rao
pushed a commit
to pallavi-rao/falcon
that referenced
this pull request
Feb 16, 2018
…ception …ception. Author: bvellanki <bvellanki@hortonworks.com> Reviewers: " Praveen Adlakha <adlakha.praveen@gmail.com>, yzheng-hortonworks <yzheng@hortonworks.com>, Venkat Ranganathan <venkat@hortonworks.com>" Closes apache#117 from bvellanki/FALCON-1909
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ception.