FELIX-6313 - handle modules names that are different from BSN#25
Merged
tjwatson merged 1 commit intoapache:masterfrom Jul 29, 2020
Merged
FELIX-6313 - handle modules names that are different from BSN#25tjwatson merged 1 commit intoapache:masterfrom
tjwatson merged 1 commit intoapache:masterfrom
Conversation
JPMS modules may have a name that does not match the Bundle-SymbolicName specified in the module bundle manifest. OSGi require-bundle symantics closely match the symantics of JMPS module requires. The require-bundle wire in OSGi is a natural fit when trying to map non-OSGi JPMS modules as OSGi connect bundles in Atomos. But this mapping depends on the BSN and the module names to match. When they don't then the conversion of a module requires to a require-bundle needs to account for the fact that the required module will have a different BSN within the OSGi framework. This change detects the mismatch and will use the correct BSN for the require-bundle wire for the connect bundle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JPMS modules may have a name that does not match the
Bundle-SymbolicName specified in the module bundle manifest.
OSGi require-bundle symantics closely match the symantics
of JMPS module requires. The require-bundle wire in OSGi
is a natural fit when trying to map non-OSGi JPMS modules
as OSGi connect bundles in Atomos. But this mapping depends
on the BSN and the module names to match. When they don't
then the conversion of a module requires to a require-bundle
needs to account for the fact that the required module will
have a different BSN within the OSGi framework.
This change detects the mismatch and will use the correct
BSN for the require-bundle wire for the connect bundle.