FELIX-6542 ScriptedHealthCheck should handle ScriptEngineFactory defined in a fragment bundle #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groovy-all bundle doesn't exist after version 2.5 so change the text to groovy-jsr223
cziegeler
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ScriptEnginesTracker in the Felix Health Check General Checks should handle loading of ScriptEngineFactory serviceloader (/META-INF/services/javax.script.ScriptEngineFactory) files that exist in a fragment.
For example, consider the groovy ScriptEngine that has these:
Host Bundle - org.codehaus.groovy:groovy:3.0.9
Fragment - org.codehaus.groovy:groovy-jsr223:3.0.9
Expected:
The groovy ScriptEngineFactory declared in the groovy-jsr223 fragment should be discovered and made available.