[FELIX-6274] Fix possible LogService ClassCastException#27
Merged
tjwatson merged 2 commits intoapache:masterfrom Jun 16, 2020
Merged
[FELIX-6274] Fix possible LogService ClassCastException#27tjwatson merged 2 commits intoapache:masterfrom
tjwatson merged 2 commits intoapache:masterfrom
Conversation
Create a simple test which shows component bundles using different incompatible versions of the log service can't be properly handled by Felix SCR due to a ClassCastException Signed-off-by: Tim Ward <timothyjward@apache.org>
The OSGi R7 LogService introduced the LoggerFactory which allows SCR to get the Logger for another bundle without having to resort to using the extendee bundles context to get the LogService. This allows SCR to use the log package SCR is wired to without having to worry about the package that the extendee is wired to for log. It also simplifies much with how SCR logs and it keeps the log entries for all bundles that SCR extends flowing through the same LogService that SCR uses instead of disjointly though all the different LogServices the extendees may be wired to. Change-Id: I4f1169adf089b34fb460f4b2f40607c17948c909 Signed-off-by: Thomas Watson <tjwatson@us.ibm.com>
Contributor
|
+1 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.