FELIX-6041 - allow scr commands to work when gogo.runtime resolves later #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the optional dependency on org.apache.felix.service.command package to allow gogo.runtime to be installed and resolved after the SCR bundle. This allows the scr gogo commands to work while avoiding a wire from the SCR bundle to the gogo packages. This is achieved by generating a proxy instance of the Converter service and registering it with the gogo.runtime BundleContext (or what ever bundle registers the CommandProcessor service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the optional dependency on org.apache.felix.service.command
package to allow gogo.runtime to be installed and resolved after the SCR
bundle. This allows the scr gogo commands to work while avoiding a wire
from the SCR bundle to the gogo packages.
This is achieved by generating a proxy instance of the Converter service
and registering it with the gogo.runtime BundleContext (or what ever
bundle registers the CommandProcessor service.