[Enhancement] column width

[HenryGyu]

Search before asking

• I searched in the issues and found nothing similar.

Motivation

When I globally enable adaptive column width, the column width specified through @column will become invalid. Can I prioritize the specified column width and use adaptive column width when not specified。

当我全局开启了自适应列宽后，通过@column指定的列宽会失效，能否优先取指定的列宽，当未指定时，使用自适应列宽

Solution

No response

Alternatives

No response

Anything else?

No response

Are you willing to submit a PR?

• I'm willing to submit a PR!

[delei]

Hi, @HenryGyu

Thank you for your feedback. Could you please provide a simple runnable sample code that contains the Excel sample file? This will help to better understand this issue.

It seems that what you meant was the @ColumnWidth annotation.

[HenryGyu]

Hi, @HenryGyu

Thank you for your feedback. Could you please provide a simple runnable sample code that contains the Excel sample file? This will help to better understand this issue.

It seems that what you meant was the @ColumnWidth annotation.

Yes, when LongestMatchColumnWidthStyleStrategy + @ColumnWidth are used together, @ColumnWidth will not take effect. I hope the priority of @ColumnWidth is higher. Thank you very much.

[ongdisheng]

I think this issue occurs because LongestMatchColumnWidthStyleStrategy and the manual @ColumnWidth handler operate independently, and they both call sheet.setColumnWidth() on the same columns. Below is the current execution order:

1. Manual width handler applies @ColumnWidth annotations first
2. LongestMatchColumnWidthStyleStrategy runs afterward for every cell including header and data rows
3. The strategy overwrites the manual widths because it doesn't check if a manual width was already set

Proposed Approach

I think we can add a check to skip adaptive width calculation when @ColumnWidth is present:

// LongestMatchColumnWidthStyleStrategy.java
@Override
protected void setColumnWidth(...) {
    boolean needSetWidth = isHead || !CollectionUtils.isEmpty(cellDataList);
    if (!needSetWidth) {
        return;
    }

+   // Skip adaptive width if manual @ColumnWidth is specified
+   if (head != null && head.getColumnWidthProperty() != null) {
+       return;
+   }

    // Continue with adaptive width calculation only for columns without @ColumnWidth
    Map<Integer, Integer> maxColumnWidthMap = ...
}

This can help to ensure:

• Columns with @ColumnWidth: Use the manual width and adaptive strategy skips them
• Columns without @ColumnWidth: Use adaptive width based on content

Feel free to share any feedback or suggestions on this approach!

[HenryGyu]

I think this issue occurs because LongestMatchColumnWidthStyleStrategy and the manual @ColumnWidth handler operate independently, and they both call sheet.setColumnWidth() on the same columns. Below is the current execution order:

1. Manual width handler applies @ColumnWidth annotations first
2. LongestMatchColumnWidthStyleStrategy runs afterward for every cell including header and data rows
3. The strategy overwrites the manual widths because it doesn't check if a manual width was already set

Proposed Approach

I think we can add a check to skip adaptive width calculation when @ColumnWidth is present:

// LongestMatchColumnWidthStyleStrategy.java
@OverRide
protected void setColumnWidth(...) {
boolean needSetWidth = isHead || !CollectionUtils.isEmpty(cellDataList);
if (!needSetWidth) {
return;
}

• // Skip adaptive width if manual @ColumnWidth is specified

• if (head != null && head.getColumnWidthProperty() != null) {

•   return;
  

• }

  // Continue with adaptive width calculation only for columns without @ColumnWidth
  Map<Integer, Integer> maxColumnWidthMap = ...
  }
  This can help to ensure:

• Columns with @ColumnWidth: Use the manual width and adaptive strategy skips them
• Columns without @ColumnWidth: Use adaptive width based on content

Feel free to share any feedback or suggestions on this approach!

Great, this solved my problem. Thank you very much!