feat: support Java Platform Module System#618
Closed
alaahong wants to merge 4 commits intoapache:mainfrom
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the Java Platform Module System (JPMS) to Apache Fesod, enabling the library to be used as a named module in Java 9+ environments while maintaining Java 8 compatibility.
- Adds JPMS module descriptor (
module-info.java) with appropriate exports and dependencies - Implements comprehensive module tests to verify module functionality and consumer usage
- Updates build configuration to compile module descriptor only on JDK 9+
- Refactors test utilities to work properly in modular environments
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| fesod/src/main/java9/module-info.java | Defines the JPMS module with exports and dependencies |
| fesod/pom.xml | Adds Java 9+ profile for module compilation and testing |
| fesod/src/test/java9/org/apache/fesod/excel/module/*.java | Module-specific tests for verification |
| fesod/src/test/java/org/apache/fesod/excel/util/TestFileUtil.java | Refactored for module path compatibility |
| website/**.md | Documentation updates for module maintenance |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fesod/src/test/java9/org/apache/fesod/excel/module/ConsumerModuleUsageTest.java
Show resolved
Hide resolved
fesod/src/test/java9/org/apache/fesod/excel/module/ConsumerModuleUsageTest.java
Show resolved
Hide resolved
Member
Author
|
Close by might not the time to push this. More discussion welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Related: #101 #332
Still confuse on the verification
What's changed?
java9 folder for JDK 9+ compile
Checklist