Skip to content

FINERACT-822 enable JdkObsolete error#1004

Merged
xurror merged 1 commit intoapache:developfrom
percyashu:JdkObsolete
Jun 8, 2020
Merged

FINERACT-822 enable JdkObsolete error#1004
xurror merged 1 commit intoapache:developfrom
percyashu:JdkObsolete

Conversation

@percyashu
Copy link
Contributor

Copy link
Member

@vorburger vorburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@percyashu
Copy link
Contributor Author

@xurror @awasum @vorburger merge this?

Copy link
Contributor

@xurror xurror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Squash the commits and this will be good to go. That is once the build passes.

@awasum
Copy link
Contributor

awasum commented Jun 8, 2020

Woow... @vorburger Error Prone is an eye opener. Thanks for the recommendation to use this.

For this issue: https://errorprone.info/bugpattern/JdkObsolete

I will never work on a project without first adding code quality checks.

@percyashu percyashu requested a review from xurror June 8, 2020 10:17
@xurror xurror merged commit 731079e into apache:develop Jun 8, 2020
Copy link
Contributor

@xurror xurror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@percyashu percyashu deleted the JdkObsolete branch June 9, 2020 02:41
@vorburger
Copy link
Member

@awasum you should TWEET that at me? ;-) I'll Like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants