FINERACT-857: Fixing scheduler integration tests and migrating to executeAndAwaitJob#1049
FINERACT-857: Fixing scheduler integration tests and migrating to executeAndAwaitJob#1049vorburger merged 2 commits intoapache:developfrom
Conversation
|
OK - looks like turning off lazy loading for group means that we have more than 61 (!) tables in a join in RecurringDeposit, which then breaks... so need to find a way to get the lazy loading to work after all... |
1d3afee to
ddef698
Compare
vorburger
left a comment
There was a problem hiding this comment.
Cool!! You are amazing. Some minor feedback..
PS: I'll search in JIRA for the open real bugs you have also fixed here.
...r/src/main/java/org/apache/fineract/scheduledjobs/service/ScheduledJobRunnerServiceImpl.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/apache/fineract/scheduledjobs/service/ScheduledJobRunnerServiceImpl.java
Outdated
Show resolved
Hide resolved
...ract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java
Outdated
Show resolved
Hide resolved
vorburger
left a comment
There was a problem hiding this comment.
LGTM! Would love to merge this ASAP.
@ptuomola if you are on and want to do this ASAP, it may avoid new conflicts for #943 which I'd like to do in the coming hours. If I don't hear from you, perhaps I'll even exceptionally resolve the conflict myself just to be able to merge this sooner rather then later - I'm sure you wouldn't mind.
|
Actually the merge conflict here was due to #1020 and trivial to resolve - I have, for once, just used GitHub's Web UI ... if I didn't screw it up, hopefully this will pass the build and I'll merge it. |
Description
Fixed two bugs that were triggered by scheduler integration tests:
Also changed triggering of jobs to use executeAndAwaitJob() and fixed logging for exceptions jobs
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
Integration tests have been created/updated for verifying the changes made.
All Integrations tests are passing with the new commits.
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide