Skip to content

add missing useJUnitPlatform() to make Gradle run JUnit 5 [FINERACT-1021]#1054

Merged
vorburger merged 2 commits intoapache:developfrom
vorburger:FINERACT-1021_JUnit5-gradle
Jun 14, 2020
Merged

add missing useJUnitPlatform() to make Gradle run JUnit 5 [FINERACT-1021]#1054
vorburger merged 2 commits intoapache:developfrom
vorburger:FINERACT-1021_JUnit5-gradle

Conversation

@vorburger
Copy link
Member

@vorburger vorburger commented Jun 14, 2020

see #1020 and FINERACT-1021 ...

@vorburger
Copy link
Member Author

This will fail with 14 integration test failures... 😢 @xurror I doubt you actually ran all tests in #1020.

The failures seems to be due to some parameter order mix up - I'm checking if I can easily fix them myself quickly. If not, I'll (have to..) sink more team into figuring out how to fully revert #1020 cleanly instead (PITA, just fixing is likely faster).

@vorburger vorburger merged commit 67e6e27 into apache:develop Jun 14, 2020
@xurror
Copy link
Contributor

xurror commented Jun 14, 2020

This will fail with 14 integration test failures... @xurror I doubt you actually ran all tests in #1020.

The failures seems to be due to some parameter order mix up - I'm checking if I can easily fix them myself quickly. If not, I'll (have to..) sink more team into figuring out how to fully revert #1020 cleanly instead (PITA, just fixing is likely faster).

I ran the tests, some must have excaped my vigilence. Thanks for your followup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants