FINERACT-821 Added and Enforced ParenPad Checkstyle#1065
Merged
vorburger merged 1 commit intoapache:developfrom Jun 16, 2020
Merged
FINERACT-821 Added and Enforced ParenPad Checkstyle#1065vorburger merged 1 commit intoapache:developfrom
vorburger merged 1 commit intoapache:developfrom
Conversation
vorburger
requested changes
Jun 15, 2020
Member
vorburger
left a comment
vorburger
left a comment
There was a problem hiding this comment.
Wait a second, these // comments that are "glued" to the code without space look weird, no? Wouldn't this be nicer with a space?
vorburger
requested changes
Jun 15, 2020
Member
vorburger
left a comment
vorburger
left a comment
There was a problem hiding this comment.
Oh this is only for inside a parenthesis... how about just removing the useless comments, and putting the useful ones in the line above instead of inside the parenthesis?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer: https://issues.apache.org/jira/browse/FINERACT-821
Thanks to spotless again ;) #1055