Skip to content

fix error at loan repayment fineract-1054#1139

Closed
francisguchie wants to merge 2 commits intoapache:developfrom
francisguchie:fixFINERACT1054
Closed

fix error at loan repayment fineract-1054#1139
francisguchie wants to merge 2 commits intoapache:developfrom
francisguchie:fixFINERACT1054

Conversation

@francisguchie
Copy link
Contributor

Description

https://issues.apache.org/jira/browse/FINERACT-1054

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide

Copy link
Contributor

@awasum awasum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change anything in the Gradle properties file.

@awasum
Copy link
Contributor

awasum commented Jul 3, 2020

Fix build failure by running './gradlew :spotlessApply' to fix these violations. See error logs on Travis: https://travis-ci.org/github/apache/fineract/builds/704389208

@awasum
Copy link
Contributor

awasum commented Jul 3, 2020

Don't change anything in the Gradle properties file.

Also dont touch this file: https://github.com/apache/fineract/blob/develop/fineract-provider/gradle/wrapper/gradle-wrapper.properties

Allow it to be automatically updated. So just use take the latest changes in the above file and put in yours. I dont know if you understand me?

@francisguchie
Copy link
Contributor Author

@awasum , Let me make raise another PR

@awasum
Copy link
Contributor

awasum commented Jul 4, 2020

No, adjust it here on this branch and pr , u don't need to raise a separate pr to fix this one. Just commit to this branch on your fork..please... Do you understand me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants