FINERACT-1108 Custom-installment-in-reshedule#1211
FINERACT-1108 Custom-installment-in-reshedule#1211avikganguly01 merged 1 commit intoapache:developfrom
Conversation
fynmanoj
force-pushed
the
AL-9
branch
3 times, most recently
from
09cc156 to
c7c4185
Compare
|
@avikganguly01 knowing that @fynmanoj works with you, and assuming that you are still an active committer to this project (are you?), I was wondering if you would like to engage on code review feedback and possible eventual merge of PRs such as this one? (I don't want to be a bottleneck on this project, and won't have the spare time to help review changes like this. If there are other active committers such as @awasum @ptuomola @xurror or others reading this who want to engage on this PR, please don't let me hold you up / wait for me - I'll ignore this one, and try to help on others.) |
|
@fynmanoj this PR needs to have a JIRA issue on the ASF JIRA, instead of referencing an issue from an issue tracker that is now a downstream redistribution of Fineract. |
edcable
changed the title
There was a problem hiding this comment.
https://travis-ci.org/github/apache/fineract/builds/713293884 - Can you look at why the deadlock for financial activity type is being caused?
|
Corresponding backoffice community app UI changes are at link. |
fynmanoj
force-pushed
the
AL-9
branch
2 times, most recently
from
19066a0 to
9752366
Compare
|
Deadlock for financial activity type is being caused by a different flaky test and it seems to happen rarely, even in the absence of this PR. |
3 participants
Description
Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket
https://issues.apache.org/jira/browse/FINERACT-1108
Originally located at https://mifosforge.jira.com/browse/AL-9
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
[] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
Integration tests have been created/updated for verifying the changes made.
All Integrations tests are passing with the new commits.
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide