Skip to content

Introduce ImageResizer to simplify ImageData (FINERACT-1201)#1425

Merged
ptuomola merged 4 commits intoapache:developfrom
vorburger:FINERACT-1201_ImageResizer-II
Nov 6, 2020
Merged

Introduce ImageResizer to simplify ImageData (FINERACT-1201)#1425
ptuomola merged 4 commits intoapache:developfrom
vorburger:FINERACT-1201_ImageResizer-II

Conversation

@vorburger
Copy link
Member

@vorburger vorburger commented Oct 18, 2020

@vorburger vorburger marked this pull request as draft October 18, 2020 10:40
@vorburger
Copy link
Member Author

Draft until I double check if the changes here are covered by an integration test.

@vorburger vorburger force-pushed the FINERACT-1201_ImageResizer-II branch 2 times, most recently from bb7c98e to 9350822 Compare October 21, 2020 21:10
@vorburger
Copy link
Member Author

Draft until I double check if the changes here are covered by an integration test using #1464 (will rebase when that one is merged).

@vorburger vorburger force-pushed the FINERACT-1201_ImageResizer-II branch from 9350822 to 07ddfeb Compare October 31, 2020 17:56
@vorburger vorburger force-pushed the FINERACT-1201_ImageResizer-II branch from 07ddfeb to 69a51b0 Compare October 31, 2020 18:06
@vorburger vorburger force-pushed the FINERACT-1201_ImageResizer-II branch from 69a51b0 to a83df2d Compare October 31, 2020 18:22
@vorburger vorburger requested a review from ptuomola October 31, 2020 19:05
@vorburger
Copy link
Member Author

@ptuomola would you be willing to review this PR re. FINERACT-1201, and merge it if it LGTY?

FYI I've locally ensured that the (new) ImageTest and DocumentTest still pass with these changes.

@vorburger vorburger marked this pull request as ready for review October 31, 2020 19:06
@vorburger
Copy link
Member Author

@ptuomola just FYI this PR intentionally contains 4 separate commits which are easier to review individually.

Copy link
Contributor

@ptuomola ptuomola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ptuomola ptuomola merged commit 140c55b into apache:develop Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants