Limit fineract-client to Java 8 not 11 (FINERACT-1214)#1446
Merged
vidakovic merged 1 commit intoapache:developfrom Oct 19, 2020
Merged
Limit fineract-client to Java 8 not 11 (FINERACT-1214)#1446vidakovic merged 1 commit intoapache:developfrom
vidakovic merged 1 commit intoapache:developfrom
Conversation
Member
Author
|
@vidakovic as per our discussion on JIRA... LGTY like this? Merge? |
Member
Author
OK, so... do you want to merge this? 😄 |
Member
Author
|
More generally, as a committer, please don't be shy to merge more PRs! Watch the Repo, jump on stuff - e.g. those from renovate-bot - all yours if they LGTY! 😸 Likewise, if I tag you as the only Reviewer, if it's fine for you, and passed the build - just merge it! 😈 |
Contributor
|
Will do... here: just waited for the build to finish ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see discussion in FINERACT-1214