Skip to content

FINERACT-1231: SDK Swagger Java Client generated utilities are broken…#1455

Merged
vorburger merged 1 commit intoapache:developfrom
vidakovic:feature/FINERACT-1231
Oct 21, 2020
Merged

FINERACT-1231: SDK Swagger Java Client generated utilities are broken…#1455
vorburger merged 1 commit intoapache:developfrom
vidakovic:feature/FINERACT-1231

Conversation

@vidakovic
Copy link
Copy Markdown
Contributor

@vidakovic vidakovic commented Oct 21, 2020

@vorburger please see if this works for you

FINERACT-1231

@vidakovic vidakovic requested a review from vorburger October 21, 2020 07:28
@vidakovic vidakovic self-assigned this Oct 21, 2020
@vorburger
Copy link
Copy Markdown
Member

@vidakovic oh, I was just too stupid to figure out ignoreFileOverride.. 😸 Thank You!

Let's wait to rebase this as soon as we have #1452 in.

@vidakovic vidakovic force-pushed the feature/FINERACT-1231 branch from 69e21ac to d666b9a Compare October 21, 2020 12:43
@vorburger vorburger closed this Oct 21, 2020
@vorburger
Copy link
Copy Markdown
Member

Closed and re-opening because of build failure due to FINERACT-1236.

Copy link
Copy Markdown
Member

@vorburger vorburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks! Will merge when green build. #1457 builds upon and extends this.

@vorburger vorburger merged commit e2aa84a into apache:develop Oct 21, 2020
@@ -0,0 +1,11 @@
**/README.md
**/pom.xml
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here either of pom.xml or gradle files are required for building the generated client SDK right? Or are we following any other method to build the generated SDK here?

@vorburger @vidakovic

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the build.gradle file of fineract-client and figured out buildJavaSdk.

After executing this task, the SDK is generated but since pom.xml or any of the gradle build scripts are excluded, I couldn't build the generated SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants