Skip to content

FINERACT-1241-elastic-web-hook#1475

Closed
fynmanoj wants to merge 1 commit intoapache:developfrom
fynmanoj:newdev
Closed

FINERACT-1241-elastic-web-hook#1475
fynmanoj wants to merge 1 commit intoapache:developfrom
fynmanoj:newdev

Conversation

@fynmanoj
Copy link
Copy Markdown
Contributor

@fynmanoj fynmanoj commented Oct 31, 2020

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@vorburger vorburger self-requested a review October 31, 2020 15:16
Copy link
Copy Markdown
Member

@vorburger vorburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fynmanoj I'm about to revert your #1466 in #1474 because it's (one of 3 things which) broke the build, see FINERACT-1241.

When that's done, this will be conflict (be invalid - because the code will have been removed).

So you'll need to redo FINERACT-1241 without test failure, and can then do that as part of it.

@fynmanoj fynmanoj closed this Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants