FINERACT-1241-elastic-web-hook-update#1488
Conversation
vorburger
left a comment
vorburger
left a comment
There was a problem hiding this comment.
@fynmanoj nice! This will "conflict" with my #1486 from yesterday.. would you be willing to review that PR and if you are OK with it have @avikganguly01 who is a committer first merge that one for me (if it looks good to both of you) and then rebase this on it and make the required retrofit => retrofit2 etc. adaptations here after #1486 is merged?
|
@vorburger, sure. kindly drop me a comment here once #1486 is merged. I shall re work on this PR |
|
@fynmanoj : Michael's PR merged. |
|
/rebase |
github-actions
bot
force-pushed
the
dev-hook
branch
from
d32565c to
d4747f7
Compare
|
@fynmanoj you can rework this PR now... we would love to merge it for you when conflicts are resolved and it passes the build. |
vorburger
left a comment
vorburger
left a comment
There was a problem hiding this comment.
feedback re Gradle dependency needs to be addressed before we can merge
There was a problem hiding this comment.
@fynmanoj sorry I keep being a PITA here, but this retrofit2:converter-gson:2.1.0 here is not good - you shouldn't fix the version here - because we already fixed a version in the root fineract/build.gradle (not fineract-provider/ - but there we currently have 2.9.0 instead of your old 2.1.0.. would you be able to just drop the version number here (it should work, and get "inherited", or was there a reason why you NEED 2.1.0 specifically?
| 'com.squareup.retrofit2:converter-gson:2.1.0' | |
| 'com.squareup.retrofit2:converter-gson' |
There was a problem hiding this comment.
Just removing such lines entirely instead of leaving them commented out like this is less "cluttered" (there is always git, for history):
| // publishEvent(wrapper.entityName(), wrapper.actionName(), result); | |
| publishEvent(wrapper.entityName(), wrapper.actionName(), command, result); | |
| publishEvent(wrapper.entityName(), wrapper.actionName(), command, result); |
fynmanoj
force-pushed
the
dev-hook
branch
2 times, most recently
from
45375cc to
55b60c7
Compare
|
@vorburger, the changes metioned are added |
3 participants
FINERACT-1241
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.