Skip to content

README update for WAR file #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
avikganguly01 wants to merge 1 commit into from
Closed

README update for WAR file #1501

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ The tenants database connection details are configured [via environment variable
Instructions to build a WAR file
============
1. Clone the repository or download and extract the archive file to your local directory.
2. Run `./gradlew clean war` to build a traditional WAR file which will be created at `build/libs` directory.
2. Run `./gradlew clean war` to build a traditional WAR file which will be created at `fineract-provider/build/libs` directory.
3. Deploy this WAR to your Tomcat v9 Servlet Container.

We recommend using the JAR instead of the WAR file deployment, because it's much easier.
Copy link
Contributor Author

@avikganguly01 avikganguly01 Nov 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vorburger @vidakovic

Is this line necessary?
Is it easier to configure SSL certificate for JAR file instead of Tomcat WAR?

Copy link
Member

@vorburger vorburger Nov 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recommend that you configure the SSL certificate at all... 😄 E.g. on https://www.fineract.dev I actually do not do that! You ask how it works 😈 then? It's now documented on #1503, waiting for your review... 😄 This PR LGTM as is, to me; I wouldn't change this.

Expand Down