Skip to content

Avoid NullPointerException on calc schedule for floating rate (FINERACT-1286)#1568

Merged
ptuomola merged 1 commit intoapache:developfrom
hypercore-ai:fix/npe-on-loan-calc
Jan 11, 2021
Merged

Avoid NullPointerException on calc schedule for floating rate (FINERACT-1286)#1568
ptuomola merged 1 commit intoapache:developfrom
hypercore-ai:fix/npe-on-loan-calc

Conversation

@davidyaha
Copy link
Contributor

Description

Avoid NullPointerException when trying to calc schedule for floating-rate loans. @vorburger

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

Copy link
Contributor

@ptuomola ptuomola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ptuomola ptuomola merged commit d4aa01c into apache:develop Jan 11, 2021
@davidyaha davidyaha deleted the fix/npe-on-loan-calc branch January 12, 2021 09:45
@davidyaha
Copy link
Contributor Author

Thanks for the quick review and merge @ptuomola!

Does the Jira ticket suppose to resolve automatically? What is the flow there?
Thanks ahead!

@ptuomola
Copy link
Contributor

ptuomola commented Jan 14, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants