Skip to content

missing fields added in GetSavingsTimeline class (FINERACT-1380)#1823

Merged
ptuomola merged 1 commit intoapache:developfrom
danishjamal104:FINERACT-1380
Sep 5, 2021
Merged

missing fields added in GetSavingsTimeline class (FINERACT-1380)#1823
ptuomola merged 1 commit intoapache:developfrom
danishjamal104:FINERACT-1380

Conversation

@danishjamal104
Copy link
Contributor

Description

Missing fields added in GetSavingsTimeline class as per the api response checkout the below json response from the api.

{
    "submittedOnDate": [
      2021,
      3,
      20
    ],
    "submittedByUsername": "mifos",
    "submittedByFirstname": "App",
    "submittedByLastname": "Administrator",
    "approvedOnDate": [
      2021,
      8,
      11
    ],
    "approvedByUsername": "mifos",
    "approvedByFirstname": "App",
    "approvedByLastname": "Administrator",
    "activatedOnDate": [
      2021,
      8,
      12
    ],
    "activatedByUsername": "mifos",
    "activatedByFirstname": "App",
    "activatedByLastname": "Administrator"
  }

For more info refer Apache Fineract JIRA ticket #1380.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

Copy link
Contributor

@ptuomola ptuomola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ptuomola ptuomola merged commit 2bba201 into apache:develop Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants