NPE at AddressWritePlatformServiceImpl.addNewClientAddress() (FINERACT-1155)#1844
Merged
ptuomola merged 1 commit intoapache:developfrom Sep 21, 2021
Merged
NPE at AddressWritePlatformServiceImpl.addNewClientAddress() (FINERACT-1155)#1844ptuomola merged 1 commit intoapache:developfrom
ptuomola merged 1 commit intoapache:developfrom
Conversation
Veeshal
changed the title
Veeshal
changed the title
Contributor
|
This is a proposed fix for issue: https://issues.apache.org/jira/browse/FINERACT-1155 |
Contributor
|
Thanks for the contributing the fix - and taking the time to refactor the code! Great work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed NPE as addressTypeId was not validated.
Also converted the static validation for address field configuration parameters to dynamic with exception to addressTypeId as its always mandatory during creation.
There was spotlessJavaCheck at stream that I have ignored. Please let me know how to fix that so that the spotless is happy with my java.
issue: https://issues.apache.org/jira/browse/FINERACT-1155