Upgrade JaCoco version to 0.8.7 for suporting JDK 17 #1892
Upgrade JaCoco version to 0.8.7 for suporting JDK 17 #1892IOhacker merged 2 commits intoapache:developfrom
Conversation
|
Hi - looks like the build is failing - can you check? Once done would be great if you could squash your commits. Thanks! |
|
Hello,
It failed because Docker rate pulling issue. How can I run the Travis-CI
job again?
Community-app (openmf/community-app:latest)...
1372ERROR: toomanyrequests: You have reached your pull rate limit. You
may increase the limit by authenticating and upgrading:
https://www.docker.com/increase-rate-limit
El jue, 14 oct 2021 a las 23:05, Petri Tuomola ***@***.***>)
escribió:
… Hi - looks like the build is failing - can you check? Once done would be
great if you could squash your commits. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1892 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALD2ZAX3VK6GANE4UTUNNOTUG6R6TANCNFSM5F7XGXEQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Close the pr and reopen it. Travis will run again.
…On Fri, Oct 15, 2021, 18:26 Víctor Romero ***@***.***> wrote:
Hello,
It failed because Docker rate pulling issue. How can I run the Travis-CI
job again?
Community-app (openmf/community-app:latest)...
1372ERROR: toomanyrequests: You have reached your pull rate limit. You
may increase the limit by authenticating and upgrading:
https://www.docker.com/increase-rate-limit
El jue, 14 oct 2021 a las 23:05, Petri Tuomola ***@***.***>)
escribió:
> Hi - looks like the build is failing - can you check? Once done would be
> great if you could squash your commits. Thanks!
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#1892 (comment)>,
or
> unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ALD2ZAX3VK6GANE4UTUNNOTUG6R6TANCNFSM5F7XGXEQ
>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
>
> or Android
> <
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
>.
>
>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1892 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADWPAYBN2RDVOKTCQZF6JFLUHBP5RANCNFSM5F7XGXEQ>
.
|
|
Closing the Pr for running again (no changes) |
|
Opening the PR for running again (no changes) |
|
I will execute it during the weekend, I tried but same error.
Regards
El vie, 15 oct 2021 a las 12:35, Awasum Yannick ***@***.***>)
escribió:
… Close the pr and reopen it. Travis will run again.
On Fri, Oct 15, 2021, 18:26 Víctor Romero ***@***.***> wrote:
> Hello,
>
> It failed because Docker rate pulling issue. How can I run the Travis-CI
> job again?
>
> Community-app (openmf/community-app:latest)...
>
> 1372ERROR: toomanyrequests: You have reached your pull rate limit. You
> may increase the limit by authenticating and upgrading:
> https://www.docker.com/increase-rate-limit
>
>
> El jue, 14 oct 2021 a las 23:05, Petri Tuomola ***@***.***>)
> escribió:
>
> > Hi - looks like the build is failing - can you check? Once done would
be
> > great if you could squash your commits. Thanks!
> >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub
> > <#1892 (comment)>,
> or
> > unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/ALD2ZAX3VK6GANE4UTUNNOTUG6R6TANCNFSM5F7XGXEQ
> >
> > .
> > Triage notifications on the go with GitHub Mobile for iOS
> > <
>
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> >
> > or Android
> > <
>
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> >.
> >
> >
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#1892 (comment)>,
or
> unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ADWPAYBN2RDVOKTCQZF6JFLUHBP5RANCNFSM5F7XGXEQ
>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1892 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALD2ZAVUUPJR6T4WVKN4U5DUHBQ73ANCNFSM5F7XGXEQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
@IOhacker Please try reopening again. |
|
Reopening now wont solve the problem as we can have a max of 100 pulls from DockerHub within a 6 hour period.. See: https://www.docker.com/increase-rate-limits So we have to wait tomorrow to close and reopen this PR. |
Yeah |
|
Closing the PR for running again (no changes) |
|
Opening the PR for running again (no changes) |
|
It has passed all the tests. Can it be merged? I will continue to work on
JDK 17.
Regards
El vie, 15 oct 2021 a las 23:24, Benura Abeywardena (<
***@***.***>) escribió:
… Reopening now wont solve the problem as we can have a max of 100 pulls
from DockerHub within a 6 hour period.. See:
https://www.docker.com/increase-rate-limits
So we have to wait tomorrow to close and reopen this PR.
Yeah
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1892 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALD2ZAQXLZN3HETJ4KOM6DLUHD5ATANCNFSM5F7XGXEQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Can you squash the commits to one (with appropriate description) please? I'll merge once done |
Description
With the upgrade to JaCoco 0.8.7 the Fineract Code Base will be prepared to be tested with the new JDK 17 which extends the support until 2026 it is related to https://issues.apache.org/jira/browse/FINERACT-1407
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.