Skip to content

Upgrade JaCoco version to 0.8.7 for suporting JDK 17 #1892

Merged
IOhacker merged 2 commits intoapache:developfrom
openMF:develop
Oct 17, 2021
Merged

Upgrade JaCoco version to 0.8.7 for suporting JDK 17 #1892
IOhacker merged 2 commits intoapache:developfrom
openMF:develop

Conversation

@IOhacker
Copy link
Contributor

Description

With the upgrade to JaCoco 0.8.7 the Fineract Code Base will be prepared to be tested with the new JDK 17 which extends the support until 2026 it is related to https://issues.apache.org/jira/browse/FINERACT-1407

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@ptuomola
Copy link
Contributor

Hi - looks like the build is failing - can you check? Once done would be great if you could squash your commits. Thanks!

@IOhacker
Copy link
Contributor Author

IOhacker commented Oct 15, 2021 via email

@awasum
Copy link
Contributor

awasum commented Oct 15, 2021 via email

@IOhacker
Copy link
Contributor Author

Closing the Pr for running again (no changes)

@IOhacker IOhacker closed this Oct 15, 2021
@IOhacker
Copy link
Contributor Author

Opening the PR for running again (no changes)

@IOhacker IOhacker reopened this Oct 15, 2021
@IOhacker
Copy link
Contributor Author

IOhacker commented Oct 15, 2021 via email

@BLasan
Copy link
Member

BLasan commented Oct 15, 2021

@IOhacker Please try reopening again.

@awasum
Copy link
Contributor

awasum commented Oct 15, 2021

Reopening now wont solve the problem as we can have a max of 100 pulls from DockerHub within a 6 hour period.. See: https://www.docker.com/increase-rate-limits

So we have to wait tomorrow to close and reopen this PR.

@BLasan
Copy link
Member

BLasan commented Oct 16, 2021

Reopening now wont solve the problem as we can have a max of 100 pulls from DockerHub within a 6 hour period.. See: https://www.docker.com/increase-rate-limits

So we have to wait tomorrow to close and reopen this PR.

Yeah

@IOhacker
Copy link
Contributor Author

Closing the PR for running again (no changes)

@IOhacker IOhacker closed this Oct 16, 2021
@IOhacker
Copy link
Contributor Author

Opening the PR for running again (no changes)

@IOhacker IOhacker reopened this Oct 16, 2021
@IOhacker
Copy link
Contributor Author

IOhacker commented Oct 17, 2021 via email

Copy link
Member

@BLasan BLasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ptuomola
Copy link
Contributor

Can you squash the commits to one (with appropriate description) please? I'll merge once done

@IOhacker IOhacker merged commit dfd69f3 into apache:develop Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants