Skip to content

Fix: Loan Collateral for multi disbursement#1943

Merged
ptuomola merged 1 commit intoapache:developfrom
BLasan:loan-collateral-optional
Nov 3, 2021
Merged

Fix: Loan Collateral for multi disbursement#1943
ptuomola merged 1 commit intoapache:developfrom
BLasan:loan-collateral-optional

Conversation

@BLasan
Copy link
Copy Markdown
Member

@BLasan BLasan commented Nov 1, 2021

Description

See FINERACT-1424

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@BLasan BLasan force-pushed the loan-collateral-optional branch from 21e3f2f to e11ef9e Compare November 2, 2021 11:57
@BLasan
Copy link
Copy Markdown
Member Author

BLasan commented Nov 2, 2021

@ptuomola @awasum Non related tests are failing. Before repushing (without any new changes) it was a test related to ShareAccount

  Test testDateFormat() FAILED (3.9s)
  java.lang.AssertionError: 1 expectation failed.
  Expected status code <202> but was <500>.
      at org.apache.fineract.integrationtests.SchedulerJobsTest.testDateFormat(SchedulerJobsTest.java:74)

@ptuomola
Copy link
Copy Markdown
Contributor

ptuomola commented Nov 3, 2021

@BLasan Let's try again - many of the other builds have passed today without this error, so it would be very strange if only this one keeps failing...

@ptuomola ptuomola closed this Nov 3, 2021
@ptuomola ptuomola reopened this Nov 3, 2021
Copy link
Copy Markdown
Contributor

@ptuomola ptuomola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BLasan
Copy link
Copy Markdown
Member Author

BLasan commented Nov 3, 2021

@ptuomola Thanks for the review. Build succeeded :)

@ptuomola ptuomola merged commit 790b2cf into apache:develop Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants