Skip to content

Fixing deployment to Fineract.dev#2014

Merged
vidakovic merged 1 commit into
apache:developfrom
ptuomola:upgrade-fineract-dev
Jan 3, 2022
Merged

Fixing deployment to Fineract.dev#2014
vidakovic merged 1 commit into
apache:developfrom
ptuomola:upgrade-fineract-dev

Conversation

@ptuomola
Copy link
Copy Markdown
Contributor

@ptuomola ptuomola commented Jan 2, 2022

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

Copy link
Copy Markdown
Contributor

@vidakovic vidakovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ptuomola
Copy link
Copy Markdown
Contributor Author

ptuomola commented Jan 4, 2022

@vorburger this was my attempt to fix the errors you highlighted... but unfortunately looks like this does not work: I can see from the Cloud Build Console that the builds are failing, but I can't see why - just get an error message saying "Error: Caller does not have permission" when I try to view the build logs. The step it fails is: "build -t gcr.io/vorburger-learn-appengin/fineract:develop fineract.git". I'll revert the PR to get the builds to pass again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants