Fineract 1510#2046
Conversation
|
@fynmanoj looks like a |
|
@fynmanoj : Some checkstyle errors are there in SavingsAccount files which is failing the basicauth build. |
fynmanoj
force-pushed
the
FINERACT-1510
branch
3 times, most recently
from
ff2bdfa to
90025dd
Compare
|
testApplyAnnualFeeForSavingsJobOutcome seems to be failing. Is it passing if you run that test separate from all the other integration tests? |
fynmanoj
force-pushed
the
FINERACT-1510
branch
from
90025dd to
854971d
Compare
|
I have changed migration script to liquibase format. Also this migration script is running fine in my local when ran separately |
|
@fynmanoj : testAccountBalanceAfterSavingsTransactionReversalPosting() FAILED |
fynmanoj
force-pushed
the
FINERACT-1510
branch
2 times, most recently
from
dcd5107 to
b0c8e14
Compare
fynmanoj
force-pushed
the
FINERACT-1510
branch
from
b0c8e14 to
b160b4a
Compare
| <changeSet author="fineract" id="1"> | ||
| <addColumn tableName="m_savings_account_transaction"> | ||
| <column name="original_transaction_id" type="BIGINT"/> | ||
| <column name="is_reversal" type="TINYINT" defaultValueNumeric="0"> |
There was a problem hiding this comment.
This got merged before I could take a look. Could you please modify this column to be type of BOOLEAN instead of TINYINT? The PostgreSQL support just got merged an hour before this and TINYINT -> BOOLEAN conversion is not automatic for PostgreSQL.
There was a problem hiding this comment.
ok, I shall send a new PR
There was a problem hiding this comment.
@galovics , hope the change TINYINT -> BOOLEAN will not affect MySQL migration
There was a problem hiding this comment.
Thanks @fynmanoj. It's not gonna be an issue for MySQL for sure.
4 participants
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.