FINERACT-1483: fix Sonar bugs with Blocker and Critical severity#2144
Merged
vidakovic merged 1 commit intoapache:developfrom Mar 22, 2022
Merged
FINERACT-1483: fix Sonar bugs with Blocker and Critical severity#2144vidakovic merged 1 commit intoapache:developfrom
vidakovic merged 1 commit intoapache:developfrom
Conversation
vidakovic
reviewed
Mar 11, 2022
...vider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientRepositoryWrapper.java
Outdated
Show resolved
Hide resolved
vidakovic
reviewed
Mar 11, 2022
...java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanApplicationTerms.java
Outdated
Show resolved
Hide resolved
Contributor
|
@taskain7 Thanks for the contributions. Looks like there is a checkstyle issue somewhere in the PR: https://github.com/apache/fineract/runs/5512932230?check_suite_focus=true Check the logs of the build failures above. |
taskain7
force-pushed
the
fix-sonar-bugs
branch
from
2a4a006 to
16ae3ff
Compare
Contributor
Author
|
Thank you @awasum , I fixed, now it should pass the build |
taskain7
force-pushed
the
fix-sonar-bugs
branch
from
8f417e0 to
fb837de
Compare
vidakovic
reviewed
Mar 18, 2022
...er/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepositoryWrapper.java
Outdated
Show resolved
Hide resolved
taskain7
force-pushed
the
fix-sonar-bugs
branch
from
3c0dbbb to
65b6e8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bugs reported by Sonar with
BlockerandCriticalseverities have been fixed