Fix for datatable serialization genericResultSet in false#2314
Conversation
...main/java/org/apache/fineract/infrastructure/dataqueries/service/GenericDataServiceImpl.java
Outdated
Show resolved
Hide resolved
|
Please also add an integration test-case for this. |
59e3ec2 to
385a769
Compare
|
@josehernandezfintecheandomx could you please add a corresponding test case? |
16ec1d9 to
2f05652
Compare
Done test case added @galovics |
...ache/fineract/integrationtests/common/organisation/EntityDatatableChecksIntegrationTest.java
Outdated
Show resolved
Hide resolved
...-tests/src/test/java/org/apache/fineract/integrationtests/common/system/DatatableHelper.java
Outdated
Show resolved
Hide resolved
...-tests/src/test/java/org/apache/fineract/integrationtests/common/system/DatatableHelper.java
Outdated
Show resolved
Hide resolved
4bbe7c9 to
486cd95
Compare
|
The tests are failing: |
There was a problem hiding this comment.
Please make sure that if you read the datatable entry you assert on the result.
There was a problem hiding this comment.
As part of the Datatable action were included in the Test case, Datatable creation including a datetime field, add new record to this datatable, read in the two cases (genericResultSet in True and False) then finally delete de datatable created
There was a problem hiding this comment.
I understand the test case. My point is that the result of the datatableHelper.readDatatableEntry() method call is never checked.
For example we should check the amount of rows in the result along with their value.
...c/test/java/org/apache/fineract/integrationtests/common/system/DatatableIntegrationTest.java
Outdated
Show resolved
Hide resolved
c2b6557 to
ced53fd
Compare
...main/java/org/apache/fineract/infrastructure/dataqueries/service/GenericDataServiceImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I understand the test case. My point is that the result of the datatableHelper.readDatatableEntry() method call is never checked.
For example we should check the amount of rows in the result along with their value.
ced53fd to
f2dbfa7
Compare
f2dbfa7 to
df805e1
Compare
Description
Fix for datatable serialization
genericResultSetinfalsein the GET datatable data endpoint, due date format exception fordatetimevaluesIgnore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.