Skip to content

Fix for datatable serialization genericResultSet in false#2314

Merged
galovics merged 1 commit intoapache:developfrom
josehernandezfintecheandomx:fix/datatable_resultset
May 20, 2022
Merged

Fix for datatable serialization genericResultSet in false#2314
galovics merged 1 commit intoapache:developfrom
josehernandezfintecheandomx:fix/datatable_resultset

Conversation

@josehernandezfintecheandomx
Copy link
Copy Markdown
Contributor

Description

Fix for datatable serialization genericResultSet in false in the GET datatable data endpoint, due date format exception for datetime values

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@galovics
Copy link
Copy Markdown
Contributor

galovics commented May 5, 2022

Please also add an integration test-case for this.

@galovics
Copy link
Copy Markdown
Contributor

@josehernandezfintecheandomx could you please add a corresponding test case?

@josehernandezfintecheandomx josehernandezfintecheandomx force-pushed the fix/datatable_resultset branch 3 times, most recently from 16ec1d9 to 2f05652 Compare May 11, 2022 03:22
@josehernandezfintecheandomx
Copy link
Copy Markdown
Contributor Author

@josehernandezfintecheandomx could you please add a corresponding test case?

Done test case added @galovics

@josehernandezfintecheandomx josehernandezfintecheandomx force-pushed the fix/datatable_resultset branch 3 times, most recently from 4bbe7c9 to 486cd95 Compare May 12, 2022 03:05
@galovics
Copy link
Copy Markdown
Contributor

The tests are failing: DatatableIntegrationTest.validateCreateReadDeleteDatatableCheck(DatatableIntegrationTest.java:72)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that if you read the datatable entry you assert on the result.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of the Datatable action were included in the Test case, Datatable creation including a datetime field, add new record to this datatable, read in the two cases (genericResultSet in True and False) then finally delete de datatable created

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the test case. My point is that the result of the datatableHelper.readDatatableEntry() method call is never checked.
For example we should check the amount of rows in the result along with their value.

@josehernandezfintecheandomx josehernandezfintecheandomx force-pushed the fix/datatable_resultset branch 5 times, most recently from c2b6557 to ced53fd Compare May 13, 2022 14:46
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the test case. My point is that the result of the datatableHelper.readDatatableEntry() method call is never checked.
For example we should check the amount of rows in the result along with their value.

@galovics galovics merged commit 64bfe33 into apache:develop May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants