Fine tuning the batch APIs and minor adjustments#2324
Merged
galovics merged 1 commit intoapache:developfrom May 12, 2022
Merged
Fine tuning the batch APIs and minor adjustments#2324galovics merged 1 commit intoapache:developfrom
galovics merged 1 commit intoapache:developfrom
Conversation
galovics
force-pushed
the
batch-api-fine-tunings
branch
2 times, most recently
from
e395013 to
2cb0b38
Compare
vidakovic
reviewed
May 12, 2022
fineract-provider/src/main/java/org/apache/fineract/batch/domain/MutableUriInfo.java
Outdated
Show resolved
Hide resolved
vidakovic
reviewed
May 12, 2022
...src/test/java/org/apache/fineract/batch/command/internal/GetLoanByIdCommandStrategyTest.java
Outdated
Show resolved
Hide resolved
vidakovic
reviewed
May 12, 2022
fineract-provider/src/test/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTest.java
Outdated
Show resolved
Hide resolved
vidakovic
approved these changes
May 12, 2022
Contributor
vidakovic
left a comment
vidakovic
left a comment
There was a problem hiding this comment.
Except for the "MutableUriInfo" (suggesting different package):
LGTM
galovics
force-pushed
the
batch-api-fine-tunings
branch
from
2cb0b38 to
4b8b352
Compare
galovics
force-pushed
the
batch-api-fine-tunings
branch
from
4b8b352 to
523b14e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.