Closed
Conversation
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
galovics
requested changes
Jul 28, 2022
Contributor
galovics
left a comment
galovics
left a comment
There was a problem hiding this comment.
Please update the PR with the latest develop changes.
Also, please add test cases to verify this functionality.
Thanks.
adamsaghy
reviewed
Aug 5, 2022
| clientForUpdate.updateSavingsProduct(savingsProductId); | ||
| } | ||
|
|
||
| if (changes.containsKey(ClientApiConstants.genderIdParamName)) { |
Contributor
There was a problem hiding this comment.
@rrpawar96 Why did you override the update logic of gender?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/FINERACT-1430