Fix to accept Loan Charge amounts using locales#2393
Merged
IOhacker merged 1 commit intoapache:developfrom Aug 10, 2022
Merged
Conversation
josehernandezfintecheandomx
force-pushed
the
fix/loan_charge_amount_with_locale
branch
4 times, most recently
from
d32fb5f to
9e011fd
Compare
josehernandezfintecheandomx
force-pushed
the
fix/loan_charge_amount_with_locale
branch
from
9e011fd to
e4826a1
Compare
galovics
requested changes
Jul 28, 2022
Contributor
galovics
left a comment
galovics
left a comment
There was a problem hiding this comment.
Added a new test-case for you @josehernandezfintecheandomx . Please check it and you'll get the idea which use-case to fix. Thanks.
josehernandezfintecheandomx
force-pushed
the
fix/loan_charge_amount_with_locale
branch
from
f4235be to
f16e8fb
Compare
josehernandezfintecheandomx
force-pushed
the
fix/loan_charge_amount_with_locale
branch
from
f16e8fb to
83209cc
Compare
IOhacker
approved these changes
Aug 10, 2022
Contributor
|
LGTM |
logoutdhaval
pushed a commit
to logoutdhaval/fineract
that referenced
this pull request
Aug 12, 2022
Co-authored-by: Jose Alberto Hernandez <alberto@MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Float amount is converted incorrectly upon creating a loan charge due the lack of use of
Localein the read ofamountpassed in the jsonRead using the default Locale in
English(Current implementation)Read using the Locale in
Denmarkusing a comma (,) in the amountChecklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.