Datatables datetime fields management#2446
Merged
galovics merged 1 commit intoapache:developfrom Aug 4, 2022
Merged
Conversation
galovics
requested changes
Jul 24, 2022
Contributor
galovics
left a comment
galovics
left a comment
There was a problem hiding this comment.
@josehernandezfintecheandomx please check the failed build first, then I'll do a review.
josehernandezfintecheandomx
force-pushed
the
fix/datatable_date_fields
branch
4 times, most recently
from
3bbe6e4 to
69adc19
Compare
galovics
requested changes
Jul 25, 2022
...main/java/org/apache/fineract/infrastructure/dataqueries/service/GenericDataServiceImpl.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/fineract/infrastructure/dataqueries/service/GenericDataServiceImpl.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/fineract/infrastructure/dataqueries/service/GenericDataServiceImpl.java
Outdated
Show resolved
Hide resolved
.../org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java
Outdated
Show resolved
Hide resolved
.../org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java
Outdated
Show resolved
Hide resolved
...act-provider/src/main/resources/db/changelog/tenant/parts/0019_refactor_loan_transaction.xml
Outdated
Show resolved
Hide resolved
josehernandezfintecheandomx
force-pushed
the
fix/datatable_date_fields
branch
2 times, most recently
from
cdc5d68 to
ff32bf4
Compare
adamsaghy
reviewed
Jul 26, 2022
...main/java/org/apache/fineract/infrastructure/dataqueries/service/GenericDataServiceImpl.java
Outdated
Show resolved
Hide resolved
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/service/DateUtils.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/fineract/infrastructure/dataqueries/service/GenericDataServiceImpl.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/fineract/infrastructure/dataqueries/service/GenericDataServiceImpl.java
Outdated
Show resolved
Hide resolved
.../org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java
Outdated
Show resolved
Hide resolved
josehernandezfintecheandomx
force-pushed
the
fix/datatable_date_fields
branch
2 times, most recently
from
9b0fd45 to
2a59cc6
Compare
adamsaghy
reviewed
Jul 29, 2022
.../org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java
Outdated
Show resolved
Hide resolved
josehernandezfintecheandomx
force-pushed
the
fix/datatable_date_fields
branch
from
2a59cc6 to
1c6e879
Compare
adamsaghy
approved these changes
Jul 29, 2022
galovics
approved these changes
Aug 1, 2022
josehernandezfintecheandomx
force-pushed
the
fix/datatable_date_fields
branch
from
1c6e879 to
17dc175
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since we moved to support 3 databases (MySql, MariaDB and Postgres) and an issue arised, Fetching
datetimefield of datatables asstringgives back different dates format:YYYY-MM-DD hh:mm:ssYYYY-MM-DDThh:mm:ssChecklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.