Skip to content

[FINERACT-1690]Improve gitpod integration#2501

Merged
galovics merged 1 commit intoapache:developfrom
mwaaas:improve-gitpod-integration
Aug 17, 2022
Merged

[FINERACT-1690]Improve gitpod integration#2501
galovics merged 1 commit intoapache:developfrom
mwaaas:improve-gitpod-integration

Conversation

@mwaaas
Copy link
Contributor

@mwaaas mwaaas commented Aug 10, 2022

@vidakovic
Copy link
Contributor

@mwaaas could you please:

  • squash the commits?
  • if there's no JIra ticket: please create one and format the PR title according to the general rules ("FINERACT-XXXX: ...")

Thanks

@mwaaas mwaaas changed the title Improve gitpod integration [FINERACT-29137]Improve gitpod integration Aug 10, 2022
@mwaaas mwaaas force-pushed the improve-gitpod-integration branch from d92bb43 to f700e32 Compare August 10, 2022 14:35
@mwaaas
Copy link
Contributor Author

mwaaas commented Aug 10, 2022

@vidakovic thanks for the quick response. I have done as suggested.

Out of curiosity why squash commits, while they could be squashed during merge?

@vidakovic
Copy link
Contributor

@mwaaas ... because we don't merge, we "rebase and merge"... check the buttons here and you'll see there is no "squash and rebase". When you squash then there's no accidental merging of multiple commits (usually it's not that interesting how you got to your solution, just that you have it)... and - if I'm not mistaken - if I squash and merge via Github's UI then GH prompts me again to choose a commit message.

So... in general... it's just more convenient... thanks for squashing.

@vidakovic
Copy link
Contributor

@mwaaas ... just one more: I think you chose the wrong Jira project? It's "FINERACT" not "AAR".

@mwaaas mwaaas changed the title [FINERACT-29137]Improve gitpod integration [FINERACT-1690]Improve gitpod integration Aug 11, 2022
@mwaaas mwaaas force-pushed the improve-gitpod-integration branch from f700e32 to bedb14d Compare August 11, 2022 04:29
@mwaaas
Copy link
Contributor Author

mwaaas commented Aug 11, 2022

@mwaaas ... just one more: I think you chose the wrong Jira project? It's "FINERACT" not "AAR".

My bad I have rectified the mistake

Copy link
Contributor

@galovics galovics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galovics galovics merged commit f821841 into apache:develop Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants