Loan Delinquency Classification job#2507
Merged
galovics merged 1 commit intoapache:developfrom Aug 22, 2022
Merged
Conversation
josehernandezfintecheandomx
force-pushed
the
enhancement/delinquency_tags_job
branch
from
96a2f8c to
085cc41
Compare
adamsaghy
reviewed
Aug 15, 2022
...a/org/apache/fineract/portfolio/delinquency/service/DelinquencyWritePlatformServiceImpl.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Aug 15, 2022
...a/org/apache/fineract/portfolio/delinquency/service/DelinquencyWritePlatformServiceImpl.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Aug 15, 2022
...c/main/java/org/apache/fineract/portfolio/delinquency/api/DelinquencyApiResourceSwagger.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Aug 15, 2022
...t-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoansApiResource.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Aug 15, 2022
...apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleInstallmentRepository.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Aug 15, 2022
...ineract/portfolio/loanaccount/jobs/setloandelinquencytags/SetLoanDelinquencyTagsTasklet.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Aug 15, 2022
...ineract/portfolio/loanaccount/jobs/setloandelinquencytags/SetLoanDelinquencyTagsTasklet.java
Outdated
Show resolved
Hide resolved
adamsaghy
requested changes
Aug 15, 2022
Contributor
adamsaghy
left a comment
adamsaghy
left a comment
There was a problem hiding this comment.
Please check my comments!
josehernandezfintecheandomx
force-pushed
the
enhancement/delinquency_tags_job
branch
from
085cc41 to
6052467
Compare
Contributor
|
@josehernandezfintecheandomx Please use the fineract-client in the integration tests! That way you can test 2 in 1 :) |
josehernandezfintecheandomx
force-pushed
the
enhancement/delinquency_tags_job
branch
from
6052467 to
beb254f
Compare
Contributor
Author
I've already used even I've extended the use of this for the Loan Product and Loan Account test helpers |
josehernandezfintecheandomx
force-pushed
the
enhancement/delinquency_tags_job
branch
3 times, most recently
from
59389d0 to
56ca6f2
Compare
galovics
requested changes
Aug 18, 2022
...fineract/portfolio/loanaccount/jobs/setloandelinquencytags/SetLoanDelinquencyTagsConfig.java
Outdated
Show resolved
Hide resolved
...ineract/portfolio/loanaccount/jobs/setloandelinquencytags/SetLoanDelinquencyTagsTasklet.java
Outdated
Show resolved
Hide resolved
...ineract/portfolio/loanaccount/jobs/setloandelinquencytags/SetLoanDelinquencyTagsTasklet.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java
Outdated
Show resolved
Hide resolved
...a/org/apache/fineract/portfolio/delinquency/service/DelinquencyWritePlatformServiceImpl.java
Outdated
Show resolved
Hide resolved
...a/org/apache/fineract/portfolio/delinquency/service/DelinquencyWritePlatformServiceImpl.java
Outdated
Show resolved
Hide resolved
...a/org/apache/fineract/portfolio/delinquency/service/DelinquencyWritePlatformServiceImpl.java
Outdated
Show resolved
Hide resolved
...a/org/apache/fineract/portfolio/delinquency/service/DelinquencyWritePlatformServiceImpl.java
Outdated
Show resolved
Hide resolved
josehernandezfintecheandomx
force-pushed
the
enhancement/delinquency_tags_job
branch
from
56ca6f2 to
d455015
Compare
josehernandezfintecheandomx
force-pushed
the
enhancement/delinquency_tags_job
branch
3 times, most recently
from
5f5bce8 to
16ef1d8
Compare
josehernandezfintecheandomx
force-pushed
the
enhancement/delinquency_tags_job
branch
from
16ef1d8 to
9e72609
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
The delinquency bucket is defined and It can be configured at the product level, there should be a verification at certain period to check, update the loan account’s delinquency field according to the configuration done at the loan product level and keep the proper loan delinquency tag history to be analyzed later
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.