Skip to content

FINERACT-1693: Fix null handling of datatables#2518

Merged
galovics merged 1 commit intoapache:developfrom
adamsaghy:fix-datatable-null-handling
Aug 19, 2022
Merged

FINERACT-1693: Fix null handling of datatables#2518
galovics merged 1 commit intoapache:developfrom
adamsaghy:fix-datatable-null-handling

Conversation

@adamsaghy
Copy link
Copy Markdown
Contributor

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@adamsaghy adamsaghy force-pushed the fix-datatable-null-handling branch from fbdff80 to 1c01cac Compare August 18, 2022 19:56
@adamsaghy adamsaghy force-pushed the fix-datatable-null-handling branch from 1c01cac to 6211d56 Compare August 18, 2022 20:27
Copy link
Copy Markdown
Contributor

@galovics galovics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galovics galovics merged commit 1cbafec into apache:develop Aug 19, 2022
@adamsaghy adamsaghy deleted the fix-datatable-null-handling branch January 28, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants