FINERACT-1706: Charge back Loan Transaction - Part 1#2614
Merged
vidakovic merged 1 commit intoapache:developfrom Sep 30, 2022
Merged
Conversation
adamsaghy
reviewed
Sep 26, 2022
...provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTransaction.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Sep 26, 2022
.../src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTransactionRelation.java
Outdated
Show resolved
Hide resolved
adamsaghy
requested changes
Sep 26, 2022
Contributor
adamsaghy
left a comment
adamsaghy
left a comment
There was a problem hiding this comment.
@josehernandezfintecheandomx Please check my comments!
josehernandezfintecheandomx
force-pushed
the
enhancement/chargeback
branch
5 times, most recently
from
590cb90 to
3c6839e
Compare
adamsaghy
reviewed
Sep 28, 2022
.../java/org/apache/fineract/portfolio/loanaccount/domain/DefaultLoanLifecycleStateMachine.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Sep 28, 2022
...provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTransaction.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Sep 28, 2022
.../java/org/apache/fineract/portfolio/loanaccount/serialization/LoanEventApiJsonValidator.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Sep 28, 2022
Contributor
adamsaghy
left a comment
adamsaghy
left a comment
There was a problem hiding this comment.
Please see my comments!
adamsaghy
reviewed
Sep 28, 2022
...apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Sep 28, 2022
...apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java
Outdated
Show resolved
Hide resolved
adamsaghy
requested changes
Sep 28, 2022
Contributor
adamsaghy
left a comment
adamsaghy
left a comment
There was a problem hiding this comment.
Please check my comments!
josehernandezfintecheandomx
force-pushed
the
enhancement/chargeback
branch
2 times, most recently
from
0486a7f to
2ab2623
Compare
adamsaghy
reviewed
Sep 29, 2022
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Sep 29, 2022
...apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Sep 29, 2022
...apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java
Outdated
Show resolved
Hide resolved
josehernandezfintecheandomx
force-pushed
the
enhancement/chargeback
branch
4 times, most recently
from
8dcf1ee to
57bb6a2
Compare
adamsaghy
reviewed
Sep 30, 2022
...neract/infrastructure/event/business/domain/loan/LoanChargebackTransactionBusinessEvent.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Sep 30, 2022
...er/src/main/java/org/apache/fineract/notification/service/NotificationDomainServiceImpl.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Sep 30, 2022
...src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanTransactionsApiResource.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Sep 30, 2022
...n/java/org/apache/fineract/portfolio/loanaccount/api/LoanTransactionsApiResourceSwagger.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Sep 30, 2022
...der/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoansApiResourceSwagger.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Sep 30, 2022
.../java/org/apache/fineract/portfolio/loanaccount/serialization/LoanEventApiJsonValidator.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Sep 30, 2022
.../java/org/apache/fineract/portfolio/loanaccount/serialization/LoanEventApiJsonValidator.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Sep 30, 2022
.../java/org/apache/fineract/portfolio/loanaccount/serialization/LoanEventApiJsonValidator.java
Outdated
Show resolved
Hide resolved
adamsaghy
requested changes
Sep 30, 2022
Contributor
adamsaghy
left a comment
adamsaghy
left a comment
There was a problem hiding this comment.
Good work!
Some minor changes were requested!
josehernandezfintecheandomx
force-pushed
the
enhancement/chargeback
branch
2 times, most recently
from
b159f7e to
e60ef9e
Compare
adamsaghy
reviewed
Sep 30, 2022
...rc/main/resources/db/changelog/tenant/parts/0052_additional_flag_loan_repayment_schedule.xml
Outdated
Show resolved
Hide resolved
josehernandezfintecheandomx
force-pushed
the
enhancement/chargeback
branch
from
e60ef9e to
a3c15b0
Compare
josehernandezfintecheandomx
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a charge back transaction on the loan account, in order to post the debit to the loan account (increase the loan balance of the account)
FINERACT-1706.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.