FINERACT-1778: Introduce Lombok to staff module

[hmg65]

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• Write the commit message as per https://github.com/apache/fineract/#pull-requests

• Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

• Create/update unit or integration tests for verifying the changes made.

• Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

• Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

• Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

[galovics]

This is a bug. You're using the Staff's ID, not the Staff's Office's ID.

[galovics]

Don't see this logic

   private Staff(final Office staffOffice, final String firstname, final String lastname, final String externalId, final String mobileNo,
            final boolean isLoanOfficer, final Boolean isActive, final LocalDate joiningDate) {
        this.office = staffOffice;
        this.firstname = StringUtils.defaultIfEmpty(firstname, null);
        this.lastname = StringUtils.defaultIfEmpty(lastname, null);
        this.externalId = StringUtils.defaultIfEmpty(externalId, null);
        this.mobileNo = StringUtils.defaultIfEmpty(mobileNo, null);
        this.loanOfficer = isLoanOfficer;
        this.active = isActive == null ? true : isActive;
        deriveDisplayName(firstname);
        this.joiningDate = joiningDate;
    }

[hmg65]

@galovics @vidakovic @BLasan @thesmallstar one solution to remove this constructor is to get away with the deriveDisplayName function as well. We can just implement the contents of that function directly inside setDisplayName like this - .setDisplayName(!StringUtils.isBlank(firstname) ? lastname + ", " + firstname : lastname)

your suggestions around this?

[github-actions]

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.