FINERACT-1706: Delinquency classification including Chargeback transactions#2668
Merged
galovics merged 1 commit intoapache:developfrom Nov 2, 2022
Conversation
galovics
requested changes
Oct 14, 2022
Contributor
galovics
left a comment
galovics
left a comment
There was a problem hiding this comment.
No tests at all, please add sufficient coverage.
...a/org/apache/fineract/portfolio/delinquency/service/DelinquencyWritePlatformServiceImpl.java
Outdated
Show resolved
Hide resolved
...a/org/apache/fineract/portfolio/delinquency/service/DelinquencyWritePlatformServiceImpl.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java
Outdated
Show resolved
Hide resolved
josehernandezfintecheandomx
force-pushed
the
enhancement/delinquency_classification_with_chargeback
branch
6 times, most recently
from
e30b3bc to
fe81b32
Compare
Contributor
Author
Please review the ticket and logs of the integration tests
|
adamsaghy
reviewed
Oct 20, 2022
...ider/src/main/java/org/apache/fineract/portfolio/delinquency/domain/LoanDelinquencyData.java
Outdated
Show resolved
Hide resolved
.../test/java/org/apache/fineract/integrationtests/DelinquencyAndChargebackIntegrationTest.java
Outdated
Show resolved
Hide resolved
josehernandezfintecheandomx
force-pushed
the
enhancement/delinquency_classification_with_chargeback
branch
2 times, most recently
from
82fe25f to
abbefbf
Compare
adamsaghy
reviewed
Oct 24, 2022
...va/org/apache/fineract/portfolio/delinquency/service/DelinquencyReadPlatformServiceImpl.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Oct 24, 2022
...va/org/apache/fineract/portfolio/delinquency/service/DelinquencyReadPlatformServiceImpl.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Oct 24, 2022
...va/org/apache/fineract/portfolio/delinquency/service/DelinquencyReadPlatformServiceImpl.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Oct 24, 2022
...va/org/apache/fineract/portfolio/delinquency/service/DelinquencyReadPlatformServiceImpl.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Oct 24, 2022
...va/org/apache/fineract/portfolio/delinquency/service/DelinquencyReadPlatformServiceImpl.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Oct 24, 2022
...a/org/apache/fineract/portfolio/delinquency/service/DelinquencyWritePlatformServiceImpl.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Oct 24, 2022
...ct-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/CollectionData.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Oct 24, 2022
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Oct 24, 2022
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Oct 24, 2022
.../main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanAccountDomainServiceJpa.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Oct 24, 2022
...a/org/apache/fineract/portfolio/delinquency/service/DelinquencyWritePlatformServiceImpl.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Oct 24, 2022
...a/org/apache/fineract/portfolio/delinquency/service/DelinquencyWritePlatformServiceImpl.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Oct 24, 2022
...apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleInstallmentRepository.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Oct 24, 2022
...a/org/apache/fineract/portfolio/delinquency/service/DelinquencyWritePlatformServiceImpl.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Oct 24, 2022
...apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleInstallmentRepository.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Oct 24, 2022
...apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleInstallmentRepository.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Oct 24, 2022
...a/org/apache/fineract/portfolio/delinquency/service/DelinquencyWritePlatformServiceImpl.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Oct 24, 2022
.../test/java/org/apache/fineract/integrationtests/DelinquencyAndChargebackIntegrationTest.java
Outdated
Show resolved
Hide resolved
josehernandezfintecheandomx
force-pushed
the
enhancement/delinquency_classification_with_chargeback
branch
from
abbefbf to
2e0e7d2
Compare
josehernandezfintecheandomx
force-pushed
the
enhancement/delinquency_classification_with_chargeback
branch
13 times, most recently
from
fbd968c to
1cb7cf2
Compare
galovics
approved these changes
Oct 28, 2022
...rc/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTransactionRepository.java
Outdated
Show resolved
Hide resolved
josehernandezfintecheandomx
force-pushed
the
enhancement/delinquency_classification_with_chargeback
branch
3 times, most recently
from
bc6a0f8 to
e0afb90
Compare
josehernandezfintecheandomx
force-pushed
the
enhancement/delinquency_classification_with_chargeback
branch
from
e0afb90 to
a36150e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Delinquency/Overdue calculation should now consider the chargeback transaction if the loan account has been charged with the chargeback transactions.
FINERACT-1706.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.