FINERACT-1772: Setting Fraud attribute for a loan account#2687
Merged
galovics merged 1 commit intoapache:developfrom Oct 21, 2022
Merged
Conversation
josehernandezfintecheandomx
force-pushed
the
enhancement/loan_fraud_flag
branch
2 times, most recently
from
c01e8ba to
093a414
Compare
adamsaghy
reviewed
Oct 20, 2022
.../java/org/apache/fineract/portfolio/loanaccount/serialization/LoanEventApiJsonValidator.java
Outdated
Show resolved
Hide resolved
josehernandezfintecheandomx
force-pushed
the
enhancement/loan_fraud_flag
branch
2 times, most recently
from
9d842a8 to
9860726
Compare
adamsaghy
reviewed
Oct 20, 2022
fineract-provider/src/main/java/org/apache/fineract/commands/service/CommandWrapperBuilder.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Oct 20, 2022
...t-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanApiConstants.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Oct 20, 2022
...der/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoansApiResourceSwagger.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Oct 20, 2022
fineract-provider/src/main/java/org/apache/fineract/commands/service/CommandWrapperBuilder.java
Outdated
Show resolved
Hide resolved
josehernandezfintecheandomx
force-pushed
the
enhancement/loan_fraud_flag
branch
from
9860726 to
4d033d9
Compare
josehernandezfintecheandomx
changed the title
josehernandezfintecheandomx
force-pushed
the
enhancement/loan_fraud_flag
branch
from
4d033d9 to
0ed22ef
Compare
galovics
requested changes
Oct 21, 2022
...t-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoansApiResource.java
Outdated
Show resolved
Hide resolved
...apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java
Outdated
Show resolved
Hide resolved
fineract-provider/src/main/resources/db/changelog/tenant/changelog-tenant.xml
Outdated
Show resolved
Hide resolved
josehernandezfintecheandomx
force-pushed
the
enhancement/loan_fraud_flag
branch
from
0ed22ef to
256e5da
Compare
Contributor
|
LGTM |
josehernandezfintecheandomx
force-pushed
the
enhancement/loan_fraud_flag
branch
from
256e5da to
3bf9506
Compare
galovics
approved these changes
Oct 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
in order to mark the loan account as fraud or not. Fineract has a "fraud“ attribute field at the loan account level
FINERACT-1772.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.