Skip to content

FINERACT-1724: Fix grammar in error message#2943

Merged
adamsaghy merged 1 commit intoapache:developfrom
adamsaghy:FINERACT-1724/fix_typo
Jan 31, 2023
Merged

FINERACT-1724: Fix grammar in error message#2943
adamsaghy merged 1 commit intoapache:developfrom
adamsaghy:FINERACT-1724/fix_typo

Conversation

@adamsaghy
Copy link
Contributor

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

Copy link
Contributor

@taskain7 taskain7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy adamsaghy force-pushed the FINERACT-1724/fix_typo branch from f3164dc to 76e1a02 Compare January 31, 2023 11:45
@adamsaghy adamsaghy force-pushed the FINERACT-1724/fix_typo branch from 76e1a02 to c371e4d Compare January 31, 2023 13:47
@adamsaghy adamsaghy merged commit 25622aa into apache:develop Jan 31, 2023
@adamsaghy adamsaghy deleted the FINERACT-1724/fix_typo branch February 8, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants