[AVRO-1603]: Avro generated fixed. Added pluginmanager to settings.#2981
Conversation
buildscript build.gradle
denizhanyildiz
changed the title
| } | ||
| } | ||
|
|
||
| buildscript { |
There was a problem hiding this comment.
This is the wrong place to add this section (or the new plugin). Also: this seems to be the older way to add a Gradle plugin... which makes me a bit suspicious. When we upgrade to Gradle 8 (which is already out for a while) then these old plugins are very likely to break.
Also: not sure if lower-/uppercase for log level etc. is really an issue here? If not required to change then please leave as is to keep the PR as minimal as possible.
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| pluginManagement { |
There was a problem hiding this comment.
See my comment before... not sure if this is needed and the right place.
| org.gradle.caching=true | ||
| org.gradle.parallel=true | ||
| org.gradle.logging.level=warn | ||
| systemProp.file.encoding=utf-8 |
There was a problem hiding this comment.
Why? Usually you set Gradle properties in gradle.properties... I don't think this will have your intended outcome (that Gradle is handling everything in UTF-8)...
|
And: the title... is the prefix "AVRO-" intended? That would indicate we are trying to solve another project's issue... please pick the right Fineract Jira ticket. Thanks. |
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
2 participants
buildscript build.gradle
Description
Added avro plugin to build.gradle file.
Added pluginmnagement to settings.gradle file.
Added anotation "@SuppressWarnings" to
fineract-provider/src/main/java/org/apache/fineract/cob/COBBusinessStepServiceImpl.java Run method.
Changed syntax from build.gradle and settings.gradle.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.