Skip to content

FINERACT-1724: Sampling support for performance measurements#3084

Merged
galovics merged 1 commit intoapache:developfrom
galovics:FINERACT-1724-57
Mar 30, 2023
Merged

FINERACT-1724: Sampling support for performance measurements#3084
galovics merged 1 commit intoapache:developfrom
galovics:FINERACT-1724-57

Conversation

@galovics
Copy link
Copy Markdown
Contributor

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@galovics galovics force-pushed the FINERACT-1724-57 branch 2 times, most recently from 484faee to 4d1b8c0 Compare March 30, 2023 16:11
Copy link
Copy Markdown
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galovics
Copy link
Copy Markdown
Contributor Author

Example sampling output for Loan COB:

Sampling data for org.apache.fineract.cob.COBBusinessStepServiceImpl
-------------
ApplyChargeToOverdueLoansBusinessStep with 100 data points -> highest: 28ms, average: 15ms, median: 15ms, lowest: 13ms
ReloaderService with 600 data points -> highest: 0ms, average: 0ms, median: 0ms, lowest: 0ms
AddPeriodicAccrualEntriesBusinessStep with 100 data points -> highest: 3ms, average: 0ms, median: 0ms, lowest: 0ms
UpdateLoanArrearsAgingBusinessStep with 100 data points -> highest: 4ms, average: 2ms, median: 2ms, lowest: 2ms
SetLoanDelinquencyTagsBusinessStep with 100 data points -> highest: 3ms, average: 1ms, median: 1ms, lowest: 1ms
CheckLoanRepaymentOverdueBusinessStep with 100 data points -> highest: 1ms, average: 0ms, median: 0ms, lowest: 0ms
CheckLoanRepaymentDueBusinessStep with 100 data points -> highest: 1ms, average: 0ms, median: 0ms, lowest: 0ms

@galovics galovics merged commit 883761b into apache:develop Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants