Introduce Lombok to accountnumberformat module (FINERACT-1727)

[abhinav7sinha]

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• Write the commit message as per https://github.com/apache/fineract/#pull-requests

• Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

• Create/update unit or integration tests for verifying the changes made.

• Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

• Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

• Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

[adamsaghy]

@abhinav7sinha Please dont forget to run a checkstyle check before committing any new code. It is failing with checkstyle errors as of now.
You can run it by ./gradlew spotlessApply

[abhinav7sinha]

@abhinav7sinha Please dont forget to run a checkstyle check before committing any new code. It is failing with checkstyle errors as of now. You can run it by ./gradlew spotlessApply

Understood, thanks. Doing so now

[adamsaghy]

@abhinav7sinha Please dont forget to squash the commits!

[abhinav7sinha]

@abhinav7sinha Please dont forget to squash the commits!

done!

[adamsaghy]

@abhinav7sinha Unfortunately, it is not correct as you have merged other people PRs into your PR!
Please try to rebase instead of merge.

[abhinav7sinha]

@abhinav7sinha Unfortunately, it is not correct as you have merged other people PRs into your PR! Please try to rebase instead of merge.

got it @adamsaghy
I'm converting it to a draft while I test the changes some more

[abhinav7sinha]

@abhinav7sinha Unfortunately, it is not correct as you have merged other people PRs into your PR! Please try to rebase instead of merge.

got it @adamsaghy I'm converting it to a draft while I test the changes some more

@adamsaghy I've marked this as ready for review now, thanks!

[abhinav7sinha]

checkStyle thinks that AccountNumberFormatEnumerations has a public/default constructor, but I'm using a lombok annotation to explicitly create a Private constructor @NoArgsConstructor(access = AccessLevel.PRIVATE)

[ERROR] /home/runner/work/fineract/fineract/fineract-provider/src/main/java/org/apache/fineract/infrastructure/accountnumberformat/domain/AccountNumberFormatEnumerations.java:35:1: Utility classes should not have a public or default constructor.

Additionally, running spotlessCheck on my local mac didn't reveal this issue.

Do you have any ideas on how I could resolve this? Or do you think I may be missing something here?
@adamsaghy

[galovics]

Do you have any ideas on how I could resolve this? Or do you think I may be missing something here?

Don't use lombok for that. That's all.

[github-actions]

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.