[FINERACT-1875] Support postgresql compatibility when retrieveAllTaxGroups#3127
Closed
balancehero-neal wants to merge 1 commit intoapache:developfrom
Closed
[FINERACT-1875] Support postgresql compatibility when retrieveAllTaxGroups#3127balancehero-neal wants to merge 1 commit intoapache:developfrom
balancehero-neal wants to merge 1 commit intoapache:developfrom
Conversation
balancehero-neal
force-pushed
the
FINERACT-1875
branch
from
3cd1fc2 to
1c0ef1d
Compare
balancehero-neal
force-pushed
the
FINERACT-1875
branch
from
1c0ef1d to
a4496bd
Compare
Contributor
Author
|
I'm a little bit worried. Because there are many codes related to a similar issue. |
galovics
requested changes
Apr 15, 2023
Contributor
galovics
left a comment
galovics
left a comment
There was a problem hiding this comment.
First things first, please add an integration test to cover this use-case, otherwise it can break anytime.
Contributor
Author
|
@galovics |
Contributor
|
@balancehero-neal is this being worked on or abandoned? |
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue: FINERACT-1875
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.