Skip to content

FINERACT-1714: Capitalized titles and line breaks#3137

Closed
david-kariuki wants to merge 2 commits intoapache:developfrom
david-kariuki:develop
Closed

FINERACT-1714: Capitalized titles and line breaks#3137
david-kariuki wants to merge 2 commits intoapache:developfrom
david-kariuki:develop

Conversation

@david-kariuki
Copy link
Copy Markdown
Contributor

@david-kariuki david-kariuki commented Apr 19, 2023

Capitalize major titles and add line breaks to increase readability

@adamsaghy
Copy link
Copy Markdown
Contributor

@david-kariuki Please attach a FINERACT jira story number to your PR and commit!

@adamsaghy
Copy link
Copy Markdown
Contributor

@david-kariuki Please squash you commits!

@david-kariuki
Copy link
Copy Markdown
Contributor Author

@david-kariuki Please attach a FINERACT jira story number to your PR and commit!

How do I go about this? I made these changes on Github's markdown editor.

@adamsaghy adamsaghy changed the title Capitalized titles and line breaks FINERACT-1714: Capitalized titles and line breaks Apr 21, 2023
@adamsaghy
Copy link
Copy Markdown
Contributor

@david-kariuki I dont think you can do it from there. Is it possible to checkout the project into your machine and squash the commits and push them back for you?

…construct

FINERACT-1724: Use services instead of repositories in COB

FINERACT-1724: Set prefetch message count to 1 for COB

FINERACT-1724: Downgrade liquibase due to invalid behaviour

[FINERACT-1922] Skip business date job when business date is not enabled

FINERACT-1724: Increase schema RO password length

Capitalized titles and line breaks

Capitalize major titles and add line breaks to increase readablity

FINERACT-1921
- [x] - Rewrite error handling

FINERACT-1724: Upgrade liquibase and set proper liquibase logging
@david-kariuki
Copy link
Copy Markdown
Contributor Author

@david-kariuki Please squash you commits!

Done

@adamsaghy
Copy link
Copy Markdown
Contributor

@david-kariuki Unfortunately, we cannot merge this into this way. When you merged the latest changes into your branch, you havent rebased it, rather used merge strategy. The problem is this way it would override the develop branch git history...That is the reason why it shows all the changes which were done by others as part of your PR.

Would you please checkout the latest version of develop and apply your changes on it? Or rebase your branch with the latest develop branch?

@david-kariuki
Copy link
Copy Markdown
Contributor Author

I will checkout from the latest version and make new changes. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants