Skip to content

FINERACT-1706-Allow-Chargeback-on-payment-type-transactions#3148

Merged
adamsaghy merged 1 commit intoapache:developfrom
ruchiD:FINERACT-1706-Allow-Chargeback-on-payment-type-transactions
May 3, 2023
Merged

FINERACT-1706-Allow-Chargeback-on-payment-type-transactions#3148
adamsaghy merged 1 commit intoapache:developfrom
ruchiD:FINERACT-1706-Allow-Chargeback-on-payment-type-transactions

Conversation

@ruchiD
Copy link
Copy Markdown
Contributor

@ruchiD ruchiD commented Apr 27, 2023

Description

Integration test verifying chargeback transactions for payment type transactions.

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@ruchiD ruchiD force-pushed the FINERACT-1706-Allow-Chargeback-on-payment-type-transactions branch from 9bc03f9 to 984f617 Compare April 28, 2023 06:24
Copy link
Copy Markdown
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy adamsaghy merged commit c7e777c into apache:develop May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants