Fineract Asset Externalization models#3185
Merged
galovics merged 2 commits intoapache:developfrom May 16, 2023
Merged
Conversation
Contributor
b0c1
commented
May 15, 2023
b0c1
commented
- Liquibase database model
- JPA model
- API endpoint without implementation
b0c1
force-pushed
the
FINERACT-1926-AssetExternalization-ModuleSeparation
branch
2 times, most recently
from
9cd9864 to
2d74ab2
Compare
galovics
approved these changes
May 16, 2023
- [x] Liquibase database model - [x] JPA model - [x] API endpoint without implementation - [x] API endpoint requirements - [x] Json Serialization and Deserialization and dependencies - [x] New Authentication check interface to the core level - [x] CommandWrapperBuilder and dependencies
b0c1
force-pushed
the
FINERACT-1926-AssetExternalization-ModuleSeparation
branch
from
2d74ab2 to
deb0801
Compare
galovics
force-pushed
the
FINERACT-1926-AssetExternalization-ModuleSeparation
branch
from
b867212 to
966dae5
Compare
galovics
force-pushed
the
FINERACT-1926-AssetExternalization-ModuleSeparation
branch
from
966dae5 to
8afbf3b
Compare
adamsaghy
reviewed
May 17, 2023
| } | ||
|
|
||
| @POST | ||
| @Path("/transfers/loans//external-id/{loanExternalId}") |
adamsaghy
reviewed
May 17, 2023
| public class ExternalTransferLoanMappingData { | ||
|
|
||
| private final Long loanId; | ||
| private final String externalId; |
Contributor
There was a problem hiding this comment.
Please use ExternalId class
adamsaghy
reviewed
May 17, 2023
| @Data | ||
| public class ExternalTransferOwnerData { | ||
|
|
||
| private final String externalId; |
Contributor
There was a problem hiding this comment.
Please use ExternalId class
adamsaghy
reviewed
May 17, 2023
| * placed in the fineract-core module. | ||
| */ | ||
| @MappedSuperclass | ||
| public abstract class AbstractAuditableCustom extends AbstractPersistableCustom implements Auditable<Long, Long, LocalDateTime> { |
Contributor
There was a problem hiding this comment.
Please use AbstractAuditableWithUTCDateTimeCustom instead
adamsaghy
reviewed
May 17, 2023
| @Getter | ||
| @Setter | ||
| @NoArgsConstructor | ||
| public abstract class AbstractPersistableCustom implements Persistable<Long>, Serializable { |
Contributor
There was a problem hiding this comment.
We have two AbstractPersistableCustom now, do we need both of them?
adamsaghy
reviewed
May 17, 2023
| @Entity | ||
| @NoArgsConstructor(access = AccessLevel.PROTECTED) | ||
| @Table(name = "m_external_asset_owner") | ||
| public class ExternalAssetOwner extends AbstractAuditableCustom { |
Contributor
There was a problem hiding this comment.
Please use AbstractAuditableWithUTCDateTimeCustom instead
adamsaghy
reviewed
May 17, 2023
| public class ExternalAssetOwner extends AbstractAuditableCustom { | ||
|
|
||
| @Column(name = "external_id", nullable = false, length = 100, unique = true) | ||
| private String externalId; |
Contributor
There was a problem hiding this comment.
Please use ExternalId class
adamsaghy
reviewed
May 17, 2023
| @Table(name = "m_external_asset_owner_transfer") | ||
| @NoArgsConstructor(access = AccessLevel.PROTECTED) | ||
| @Entity | ||
| public class ExternalAssetOwnerTransfer extends AbstractAuditableCustom { |
Contributor
There was a problem hiding this comment.
Please use AbstractAuditableWithUTCDateTimeCustom instead
adamsaghy
reviewed
May 17, 2023
| @Table(name = "m_external_asset_owner_transfer_loan_mapping") | ||
| @NoArgsConstructor(access = AccessLevel.PROTECTED) | ||
| @Entity | ||
| public class ExternalAssetOwnerTransferLoanMapping extends AbstractAuditableCustom { |
Contributor
There was a problem hiding this comment.
Please use AbstractAuditableWithUTCDateTimeCustom instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.