Skip to content

FINERACT-1901 : Reject loan does not lead to NullPointer #3199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kengne-yvana wants to merge 1 commit into from
Closed

FINERACT-1901 : Reject loan does not lead to NullPointer #3199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ...structure/creditbureau/service/CreditBureauLoanProductMappingReadPlatformServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import org.apache.fineract.infrastructure.creditbureau.data.CreditBureauLoanProductMappingData;
import org.apache.fineract.infrastructure.security.service.PlatformSecurityContext;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.dao.EmptyResultDataAccessException;
import org.springframework.jdbc.core.JdbcTemplate;
import org.springframework.jdbc.core.RowMapper;
import org.springframework.stereotype.Service;
Expand Down Expand Up @@ -100,11 +101,15 @@ public Collection<CreditBureauLoanProductMappingData> readCreditBureauLoanProduc
@Override
public CreditBureauLoanProductMappingData readMappingByLoanId(long loanProductId) {
this.context.authenticatedUser();
try{
final CreditBureauLoanProductMapper rm = new CreditBureauLoanProductMapper();
final String sql = "select " + rm.schema() + " and cblp.loan_product_id=?";

final CreditBureauLoanProductMapper rm = new CreditBureauLoanProductMapper();
final String sql = "select " + rm.schema() + " and cblp.loan_product_id=?";
return this.jdbcTemplate.queryForObject(sql, rm, new Object[] { loanProductId }); // NOSONAR
}catch(EmptyResultDataAccessException e){
return null;
Copy link
Copy Markdown
Contributor

@galovics galovics May 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right way to do it. The API will respond with a null response body but it should simply signal an HTTP 404 representing a resource not found situation.

}

return this.jdbcTemplate.queryForObject(sql, rm, new Object[] { loanProductId }); // NOSONAR
}

@Override
Expand Down