[FINERACT-1926] Loan account transfer POST API fixes#3201
Merged
adamsaghy merged 1 commit intoapache:developfrom May 25, 2023
Merged
[FINERACT-1926] Loan account transfer POST API fixes#3201adamsaghy merged 1 commit intoapache:developfrom
adamsaghy merged 1 commit intoapache:developfrom
Conversation
taskain7
force-pushed
the
asset-externalization-post-api
branch
from
7f8d249 to
208a66f
Compare
adamsaghy
reviewed
May 25, 2023
taskain7
force-pushed
the
asset-externalization-post-api
branch
3 times, most recently
from
c32dbba to
cdafb51
Compare
taskain7
changed the title
taskain7
force-pushed
the
asset-externalization-post-api
branch
from
cdafb51 to
77b0d17
Compare
adamsaghy
reviewed
May 25, 2023
| final DataValidatorBuilder baseDataValidator = new DataValidatorBuilder(dataValidationErrors).resource("loantransfer"); | ||
| final JsonElement json = fromApiJsonHelper.parse(apiRequestBodyAsJson); | ||
|
|
||
| String ownerExternalId = fromApiJsonHelper.extractStringNamed(ExternalTransferRequestParameters.OWNER_EXTERNAL_ID, json); |
Contributor
There was a problem hiding this comment.
This is required only for SALE.
Contributor
Author
There was a problem hiding this comment.
based on the design doc, it's also in the request for buyback.
adamsaghy
reviewed
May 25, 2023
| baseDataValidator.reset().parameter(ExternalTransferRequestParameters.TRANSFER_EXTERNAL_ID).value(transferExternalId).ignoreIfNull() | ||
| .notExceedingLengthOf(100); | ||
|
|
||
| String purchasePriceRatio = fromApiJsonHelper.extractStringNamed(ExternalTransferRequestParameters.PURCHASE_PRICE_RATIO, json); |
Contributor
There was a problem hiding this comment.
This is required only for SALE.
Contributor
Author
There was a problem hiding this comment.
based on the design doc, it's also in the request for buyback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix for initiating transfer on loan that is not in active status.
Additional validations.
Newly created owner id is saaved for transaction.